samvera-deprecated / sufia

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.
http://sufia.io/
Other
111 stars 78 forks source link

Metadata no longer all linked #2081

Closed carolyncole closed 8 years ago

carolyncole commented 8 years ago

Descriptive summary

In Sufia 7 the work show page no longer links the metadata the same way that sufia 6 did.

Expected behavior

screen shot 2016-05-24 at 11 38 33 am

Actual behavior

screen shot 2016-05-24 at 11 41 51 am

Steps to reproduce the behavior

  1. Create a work and fill in metadata for Language, Location, subject and keyword
  2. Then visit the work show page
carolyncole commented 8 years ago

@mbklein It also looks like the links are broken.
The facet creates this link, which finds the work: http://localhost:3000/catalog?f%5Bcreator_sim%5D%5B%5D=create The link in the show page creates this link, which does not find the work: http://localhost:3000/catalog?q=create&search_field=creator

mtribone commented 8 years ago

@cam156 Good catch! I totally missed it when I worked on my PR for multiple titles and descriptions.

https://github.com/projecthydra/sufia/pull/2015

mbklein commented 8 years ago

Thanks @cam156. I'll look into that as well.

mtribone commented 8 years ago

Also get the [...] around the title of collections in relationships.

screen shot 2016-05-31 at 10 58 22 am

mjgiarlo commented 8 years ago

@mbklein are you still on this ticket, or should we reassign? If the latter, do you have any in-progress branches to push?

mbklein commented 8 years ago

I do not have any lingering work on this, and I'm not sure when I'd be able to get to the issue @mtribone pointed out. Probably best to reassign.

mjgiarlo commented 8 years ago

Thanks, @mbklein!

mjgiarlo commented 8 years ago

Do you have cycles for this one, @mtribone?

mtribone commented 8 years ago

@mjgiarlo We are sprinting on the migration plan this week, but I can pick it up next week if it isn't needed this week.

mtribone commented 8 years ago

I'm guessing that there are some overrides in Sufia that are preventing https://github.com/projecthydra/curation_concerns/pull/819 from working properly?

mtribone commented 8 years ago

I'm guessing that the search results will need linked metadata, too?!

screen shot 2016-06-07 at 12 47 12 pm

mjgiarlo commented 8 years ago

Yep, @mtribone, good call. If that feels scope creep-y to you, feel free to break that out into a different PR. If not, cool to include linked metadata in all the show/index contexts (work, catalog, collection, fileset, ... ?) in this PR. Up to you.