search

samvera-deprecated / sufia

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.
http://sufia.io/
Other
111 stars 78 forks source link

Human-readable dates for embargoes and leases #2325

Closed awead closed 8 years ago

awead commented 8 years ago

Descriptive summary

When placing a work under an embargo or lease, the date appears as a full time stamp, ex. 2016-07-27T00:00:00+00:00. It should either be just a date, or a date with a properly formatted time.

mjgiarlo commented 8 years ago

Are you still working on this, @mtribone, or is this work already done?

mtribone commented 8 years ago

@mjgiarlo Yeah made the fix in CC and waiting for it to be cut and included into Sufia.

mjgiarlo commented 8 years ago

@mtribone I believe the fix was released in CC 1.2.0, and Sufia should now pick up that release. Do you think you'll have cycles to check this and close the issue if it's all good?

mtribone commented 8 years ago

CC is still at 1.1

https://github.com/projecthydra/sufia/blob/master/sufia.gemspec#L21

mjgiarlo commented 8 years ago

@mtribone the ~> there means Sufia can use CC 1.x, so 1.2.0 should work A-OK.

https://robots.thoughtbot.com/rubys-pessimistic-operator

mtribone commented 8 years ago

Okay. I will look for an override that is preventing the expected behavior.

screen shot 2016-08-02 at 2 17 32 pm

mtribone commented 8 years ago

https://github.com/projecthydra/sufia/blob/master/app/views/curation_concerns/base/_metadata.html.erb#L8

mtribone commented 8 years ago

screen shot 2016-08-02 at 2 39 05 pm

mjgiarlo commented 8 years ago

@mtribone what'd you change to get it rendering properly?

:clap:

mtribone commented 8 years ago

metadata.html.erb ⏫ waiting for branch to go green and then PR

mjgiarlo commented 8 years ago

Ah, I see. Missed it. Thanks, @mtribone!