Test integration with Blacklight

samvera-deprecated / sufia

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.

http://sufia.io/

Other

111 stars 78 forks source link

Test integration with Blacklight #2345

Open awead opened 8 years ago

awead commented 8 years ago

Descriptive summary

We're using Blacklight's index_presenter and ought to have a minimal feature test that ensures it's doing what we need it to do. Namely, this would include:

verifying certain index fields are displayed as facetable links

Other?

mjgiarlo commented 8 years ago

See past integration testing here: https://github.com/projecthydra/sufia/blob/821fa7111865272b8130dccd62f9ce05e0d6a975/spec/helpers/blacklight_helper_spec.rb

mjgiarlo commented 8 years ago

And discussion here: https://github.com/projecthydra/sufia/issues/2341

jcoyne commented 8 years ago

I don't think we want to test the index_presenter. That is already well tested. If you want to do integration testing, you must call sufia code, not Blacklight code, otherwise there is no integration.

atz commented 8 years ago

That our helper_methods actually receive back from Blacklight arguments that we can handle. One relies on arg[:config][:field_name], for example.
itemprop
field.label
All of our helper_methods: iconify_auto_link, link_to_search, index_field_link, rights_statement_links, human_readable_date
That our generated configuration achieves the correct composite behavior.

I agree w/ Justin that an integration test is warranted, but I'll take the old helper test as a provisional measure.

atz commented 8 years ago

Also check fields' if and unless clauses.