search

samvera-deprecated / sufia

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.
http://sufia.io/
Other
111 stars 78 forks source link

When an object is deposited and mediated deposit is enabled, the object state should be set to Inactive #2616

Closed vantuyls closed 7 years ago

vantuyls commented 8 years ago

All works and file sets are marked as inactive (in draft form) when deposited, if the mediated deposit feature flipper is on. To mark an object as inactive, set its state property to ::RDF::URI('http://fedora.info/definitions/1/0/access/ObjState#inactive'. See https://github.com/projecthydra/curation_concerns/pull/928/files for the work that enabled this feature.

Decomposes #2452. Further decomposed into

mjgiarlo commented 8 years ago

What does it mean for an object to be inactive? Is it discoverable via search? If so, by whom? Is the show page visible? If so, by whom? Are its stats included in administrative stats? etc. What other questions should be be asking here? @jeremyf @jcoyne

jeremyf commented 8 years ago

For not yet approved objects, their visibility is very different from their visibility once approved. In Sipity I have a proxy object for a work. This proxy object holds the work flow state. When querying for "As a reviewer, what can I see" I use query the proxy object states and render an index of those objects.

Items that are not approved are visible to workflow participants (and only visible when the work flow state is applicable for the participant).

Jeremy Friesen

On Sep 2, 2016 2:46 PM, "Michael J. Giarlo" notifications@github.com wrote:

What does it mean for an object to be inactive? Is it discoverable via search? If so, by whom? Is the show page visible? If so, by whom? Are its stats included in administrative stats? etc. What other questions should be be asking here? @jeremyf https://github.com/jeremyf @jcoyne https://github.com/jcoyne

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/projecthydra/sufia/issues/2616#issuecomment-244457211, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAIUl9eGJ5Fa1gIPtFyRvdwIHawQXc-ks5qmG7fgaJpZM4JzM1u .

vantuyls commented 8 years ago

@mjgiarlo - Inactive object show pages are always visible to Amin Role and visible to Reviewer Role if the reviewer is part of the object's workflow.

I don't think inactive objects should be counted in admin stats, unless for some reason we want specific stats for, e.g., number of objects being processed currently.

Inactive objects are not discoverable by search.

hortongn commented 8 years ago

@randalldfloyd @scholarworks I'm grabbing this issue to work on tomorrow after https://github.com/projecthydra/sufia/pull/2645 is merged.

vantuyls commented 8 years ago

Reopening this to ensure that the issue is covered by the new Curation Concerns workflow branch and subsequent Sufia Mediated Deposit work.

scholarworks commented 7 years ago

FYI - I added the "CurationConcerns::Workflow::DeactivateObject" method to the new state of a workflow, and it appears to set the value properly:

ns007: objState http://fedora.info/definitions/1/0/access/ObjState#inactive

But the item is still publicly viewable.

mjgiarlo commented 7 years ago

@straleyb are you working on this and #2828 together (in the work you're relocating to CC)? if so, makes sense.

vantuyls commented 7 years ago

closing. this is happening in both sufia and cc.