search

samvera-deprecated / sufia

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.
http://sufia.io/
Other
111 stars 78 forks source link

Forcing dismax in CatalogSearchBuilder #2984

Open awead opened 7 years ago

awead commented 7 years ago

Descriptive summary

The CatalogSearchBuilder uses dismax

https://github.com/projecthydra/sufia/blob/master/app/search_builders/sufia/catalog_search_builder.rb#L35

This can prevent wildcard searches which need edismax. It also conflicts with the Blacklight advanced search plugin, which uses a CatalogController setting:

config.advanced_search[:query_parser] ||= 'dismax'

Which could also be set to edismax.

We could make Sufia's query parser configurable as well? Or is there a reason why dismax is required?

jcoyne commented 7 years ago

This is a good question. I have no attachment to it. This query was added by @cam156 (in 1010554cd675f20d66aafaa8439249e4c2d69587), so I'd like to see what she thinks.

jcoyne commented 7 years ago

FYI, blacklight-advanced-search use to have dismax hardcoded until I made the query parser configurable in https://github.com/projectblacklight/blacklight_advanced_search/commit/5ceff42ab6b242c52ea319373a5e6e4b7c144006

carolyncole commented 7 years ago

@awead configuration makes sense

mjgiarlo commented 7 years ago

@awead Since the question is answered, shall we close this issue, or do you want to hang PRs off it?

awead commented 7 years ago

@mjgiarlo that's up to you. The question is answered, but no actionable issues have been created. If you think Sufia/Hyrax should not support wildcard searching up-front, then close this.

mjgiarlo commented 7 years ago

OK, @awead, good point.

@jcoyne @awead @cam156 any of y'all inclined to work on supporting wildcard searching in Sufia? Might AIC be inclined to contribute this back to Sufia so they don't need to maintain that code in their app?