search

samvera-deprecated / sufia

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.
http://sufia.io/
Other
111 stars 78 forks source link

Upgrade install template for 7.3.0.rc1 #3075

Closed elrayle closed 7 years ago

elrayle commented 7 years ago

Descriptive summary

The installation template for creating a new Sufia app needs to be updated to use the 7.3.0.rc1 release.

Expected behavior

Creating a new app with template.rb should use the latest 7.3.0.rc1 Sufia gem.

Actual behavior

Creating a new app with template.rb uses 7.2.0 Sufia gem.

Steps to reproduce the behavior

  1. run rails new my_app -m https://raw.githubusercontent.com/projecthydra/sufia/master/template.rb in terminal to create a new Sufia app.

Possible solutions

Option 1:

Option 2:

This would allow a user to choose which version of Sufia to use.

jcoyne commented 7 years ago

I'm not sure we should update the template with a release candidate. Can we wait until we have a final release?

mjgiarlo commented 7 years ago

@elrayle I'm not inclined to make major changes to this in Sufia with the possibly final (7.3.0) release coming soon. (And we have a related pending PR here: https://github.com/projecthydra/sufia/pull/3071/files#diff-281a446193b96436f21d35a03e1fa073)

That said @projecthydra/sufia-code-reviewers @elrayle @jcoyne, how do you think we should handle this in Hyrax going forward? I ask because Justin and I went back and forth on this for quite some time last week, with the two options being:

  1. README always points at the template in the master branch, and the template is updated with each release to point at the latest release. This means that the README will always install the latest stable release of Hyrax.
  2. README always points at the template corresponding to the current release. So if you're reading the README for Hyrax 1.2.0, you get Hyrax 1.2.0 installed. If you're reading the README for 0.1.0, you get 0.1.0 installed. If you're reading the README in master, you get the latest stable release of Hyrax. (In order to do this, we'd need to update the README and the template with each release, as ticketed here: https://github.com/projecthydra/sufia/issues/2784)

I'd welcome folks' thoughts on this.

mjgiarlo commented 7 years ago

See also some past discussion here: https://github.com/projecthydra/sufia/pull/2783#pullrequestreview-3965724

mjgiarlo commented 7 years ago

Replaced with https://github.com/projecthydra-labs/hyrax/issues/492.