samvera-deprecated / sufia

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.
http://sufia.io/
Other
111 stars 78 forks source link

Backport changes to the workflow JSON template #3114

Closed mjgiarlo closed 7 years ago

mjgiarlo commented 7 years ago

So that folks can upgrade from Sufia 7.3.0 to Hyrax 1.0.0 without needing to migrate workflow data

jcoyne commented 7 years ago

@mjgiarlo this is going to cause breaking changes for anyone who starts with 7.3.0.rc1. Do you want to deprecate the old constant or add a note to the upgrade guide?

mjgiarlo commented 7 years ago

@jcoyne If we don't deprecate the CompleteNotification constant, what should we say in the upgrade guide? I'm concerned about folks who've loaded workflows and sent items through in rc1 -- how do we alter this workflow for them without breaking things badly?

jcoyne commented 7 years ago

@mjgiarlo I don't know.

mjgiarlo commented 7 years ago

@jcoyne FWIW, we may be in this same state, or a similar state, w/ our AWS-deployed Hyku instance. I say this because at least in the foo tenant, we seem to have an older workflow in place (still using complete as the "published" state instead of deposited).

mjgiarlo commented 7 years ago

@jeremyf Any advice on the above?

mjgiarlo commented 7 years ago

@jeremyf Are you inclined to toss a new rake task to help with database migrations for folks who upgrade from rc1 to rc2 and picked up the new JSON?

jeremyf commented 7 years ago

I'm adding the rake task this morning.

mjgiarlo commented 7 years ago

@jeremyf :clap: :tada: