search

samvera-deprecated / sufia

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.
http://sufia.io/
Other
111 stars 78 forks source link

Do not assume selector is present if it responds to length #3146

Closed mjgiarlo closed 7 years ago

mjgiarlo commented 7 years ago

Fixes #3142

Since you can reproduce this, @jcoyne, can you test this branch locally to see if it works?

jcoyne commented 7 years ago

I'm still seeing the problem in this branch. I'm assuming it's because the event is binding to $(document).on('scroll' on a page where the condition is true, and it doesn't unbind when turbolinks switches page.

mjgiarlo commented 7 years ago

@jcoyne ok. I'll nuke this branch and am inclined to move this ticket to Hyrax unless you are itching to fix this here.