search

samvera-deprecated / sufia

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.
http://sufia.io/
Other
111 stars 78 forks source link

Add null constraint to permission_templates workflow_name, fix #3156 #3158

Closed hackartisan closed 7 years ago

hackartisan commented 7 years ago

fix #3156

Question: Is this sufficient for people upgrading from sufia 7.2? Or do we also need to copy a template via an upgrade script?

hackartisan commented 7 years ago

well that wasn't nearly as simple as it looked

jcoyne commented 7 years ago

You can probably fix most of these errors by updating the permission_template factory to set workflow_name to AdminSet::DEFAULT_ID

hackartisan commented 7 years ago

set workflow_name to 'admin_set/default'?

hackartisan commented 7 years ago

okay not sure why but that seems to work.

hackartisan commented 7 years ago

okay the couple of pushes should bring this down to 5 failing tests. not sure what to do about the ones like https://travis-ci.org/projecthydra/sufia/jobs/212141228#L2197

okay looks like I can pass a block

hackartisan commented 7 years ago

looks like the permission_template table was added in 7.3.rc3 so this shouldn't need template / upgrade task infrastructure.

mjgiarlo commented 7 years ago

@hackmastera trying a rebase.

mjgiarlo commented 7 years ago

@hackmastera tossed some more deltas and squashed.

mjgiarlo commented 7 years ago

@jcoyne @hackmastera This is :green_heart: and ready for review.

mjgiarlo commented 7 years ago

Other changes I made:

mjgiarlo commented 7 years ago

:rage:

mjgiarlo commented 7 years ago

Should be easy to fix on Monday; I took things just a bit too far 😉