samvera-deprecated / sufia

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.
http://sufia.io/
Other
111 stars 78 forks source link

Visibility options for Embargo don't expand on batch create form #3166

Open hortongn opened 7 years ago

hortongn commented 7 years ago

Originally opened as https://github.com/projecthydra-labs/hyrax/issues/930

Descriptive summary

When a user is on the batch create form and clicks the radio button for "Embargo" the form does not expand to reveal the "Restricted to..." or "then open it up to.." options like it does on the single work form.

We experienced the bug on 7.3.0.

Expected behavior

Clicking on the "Embargo" radio button in the Visibility section of the batch create form should reveal additional form options.

Actual behavior

Clicking on the "Embargo" radio button in the Visibility section of the batch create form has no effect other than selecting the radio button itself.

Steps to reproduce the behavior

  1. Go to the form to create a new batch work
  2. Click on the "Embargo" radio button

Related work

University of Cincinnati has fixed this locally here: https://github.com/uclibs/scholar_uc/pull/1373/files

The problem is that the batch form doesn't include the data-behavior="work-form" in the

tag. So the JS that expands the options doesn't know what to act on.