search

samvera-deprecated / sufia

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.
http://sufia.io/
Other
111 stars 78 forks source link

Embedded video player not working #3168

Closed hortongn closed 7 years ago

hortongn commented 7 years ago

Originally opened as https://github.com/projecthydra-labs/hyrax/issues/932

Descriptive summary

When a video file is attached to a work, the file show page embeds an HTML5 video player. However, the player never loads the video.

We experienced the bug on 7.3.0.

Expected behavior

The file show page for videos should allow the user to play the video right on the page.

Actual behavior

The video player remains empty.

Steps to reproduce the behavior

  1. Create a work and attach a video
  2. Save the work and go to the file's show page
  3. The video never loads in the player

Related work

University of Cincinnati has fixed this locally here: https://github.com/uclibs/scholar_uc/pull/1353/files

The PR addresses two problems:

  1. loads the file properly into the player
  2. restricts the size of the player so it doesn't automatically expand to a much larger size when the source video is large.

Note: it can take a bit a time for the video to eventually show up in the player. Be patient.

hortongn commented 7 years ago

Enabling ffmpeg derivatives does fix the embedded player for us without any tweaks needed in the view. So I'm closing this issue. No fix is needed.