search

samvera-deprecated / sufia

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.
http://sufia.io/
Other
111 stars 78 forks source link

OPTION 3 #3184

Closed RudyOnRails closed 6 years ago

RudyOnRails commented 6 years ago

this will allow to replace the monkey patch in https://github.com/samvera/sufia/pull/3183

@jrochkind what do you think about this?

jrochkind commented 6 years ago

I don't believe this is appropriate, especially for a patch release (which is all we're trying to do in sufia pretty much forever right now).

Before this change, someone could be using sufia 7.4 with h-d 3.3.x. After this change, they would have to upgrade to 3.4.1, which maybe has other bugs we don't know about yet.

It's not appropriate to force someone to upgrade a dependency like this in a patch release, if you have any alternative.

This whole stack is so fragile, I don't want to force myself to upgrade h-d to get other potential future bugfixes in sufia.

RudyOnRails commented 6 years ago

Ok sounds good. I don't have as much experience as you do with gems and dependencies and release versions, so I'll close this. It was just my first thought, but I see how you say it could have problems.