samvera-labs / active_encode

Declare encode job classes that can be run by a variety of encoding services
Other
6 stars 8 forks source link

MediaConvert support direct 'destination' output arg #103

Closed jrochkind closed 2 years ago

jrochkind commented 2 years ago

Previously, you specified the output location by configuring output_bucket globally, and then setting output_prefix on the create call.

These are combined by code to pass to MediaConvert as an s3:// url in the destination parameter.

This PR provides an alternate option, just pass a destination arg with an s3:// url to create, not using output_bucket at all. This is an arg of the same format that MediaConvert itself uses, passed directly to MediaConvert. It is more convenient in some situations to simply pass the destinations on a per-call basis, the same way you would to MediaConvert.

jrgriffiniii commented 2 years ago

https://app.circleci.com/pipelines/github/samvera-labs/active_encode does not indicate that the CircleCI jobs are actually being run. This is currently being discussed with the CircleCI administrators, so sorry for this.