search

samvera-labs / active_encode

Declare encode job classes that can be run by a variety of encoding services
Other
6 stars 8 forks source link

[FfmpegAdapter] `#write_errors` should create exit code file to indicate failed status #130

Open cjcolvar opened 10 months ago

cjcolvar commented 10 months ago

https://github.com/samvera-labs/active_encode/blob/f35a7976d9f4e74ad4f25616a9c6900f71ade401/lib/active_encode/engine_adapters/ffmpeg_adapter.rb#L197-L199

#write_errors writes out an error.log file but not an exit_status.code which gets used in determining the status in the #find method

https://github.com/samvera-labs/active_encode/blob/f35a7976d9f4e74ad4f25616a9c6900f71ade401/lib/active_encode/engine_adapters/ffmpeg_adapter.rb#L135-L137

This leads to an issue along with #129 when a file fails in #create during inspection.

Alternatively the #find if statements could be changed to check for error.log. Although this might not work since the ffmpeg command outputs to error.log for stderr which might happen even when the command is still running or succeeds.