samvera-labs / active_encode

Declare encode job classes that can be run by a variety of encoding services
Other
6 stars 8 forks source link

Should #create! raise an ArgumentError if the instance already has an id? #38

Open cjcolvar opened 6 years ago

cjcolvar commented 6 years ago

What should happen if #create! is called on an encode instance that already has an id? Should it raise an ArgumentError or should it submit that to the adapter in an attempt to assign that id in the external encoding service? Personally, I would expect that the external service would always assign an id and that an encode instance with an id should raise an exception.