search

samvera-labs / active_encode

Declare encode job classes that can be run by a variety of encoding services
Other
6 stars 8 forks source link

Sprockets dependency #82

Closed clemensg closed 2 years ago

clemensg commented 3 years ago

Hello,

I noticed that there is a dependency on sprockets < 4 in the gemspec, which blocks the update to active_encode 0.8.1 in a Rails 6 project (which uses sprockets 4). I don't see any parts in active_encode actually using sprockets, so I would like to know why the dependency was added (the comment does not really help) and if there are any objections to removing it?

clemensg commented 3 years ago

@phuongdh Hi. According to git blame you added the sprockets dependency. Maybe you could answer why you added it and if it is still necessary? Thank you.

phuongdh commented 3 years ago

I haven't been involved with the community for a while and don't remember why sprockets is there. Feel free to submit a PR removing it.

cjcolvar commented 2 years ago

Fixed by #104