search

samvera-labs / active_encode

Declare encode job classes that can be run by a variety of encoding services
Other
6 stars 8 forks source link

support Ruby 3.0 #92

Closed jrochkind closed 2 years ago

jrochkind commented 2 years ago

My app is ruby 3.0, and I'm looking at using active_encode.

I notice it's not tested under ruby 3.0; maybe it'll pass fine anyway?

But when I was running tests locally I noticed warnings about URI.escape, which has finally been removed from ruby 3.0. (Although I can't find any examples in active_encode codebase! Have to look into it more). (It's not clear what the substitute for URI.escape is, the whole situation has been a mess).

There may be other things failing in ruby 3.0, which perhaps we'd find out from updating tests to run under 3.0.

jrochkind commented 2 years ago

I'm looking at the .circleci/config.yml to see about adding it... I notice we are not testing with anything past Rails 5.2 currently. Rails 5.2 may not actually be compatible with ruby 3.0. :(

Testing under ruby 3.0 and rails 6.1, there are a whole bunch of failures. :( Some of them are indeed URI.decode.

I guess I should change just one of these at a time and see what I can do.

cjcolvar commented 2 years ago

Closed by #96