search

samvera-labs / fedora-migrate

Gem for migrating content to Fedora4
Other
10 stars 7 forks source link

Update ruboco and rubocop-rspec, then pin their versions #53

Closed awead closed 8 years ago

awead commented 8 years ago

This should keep us insulated from Rubocop's whimsical nature.

awead commented 8 years ago

ping @coblej @barmintor this should get the gem passing, but you'll note that current versions of hydra-head and active-fedora aren't supported.

barmintor commented 8 years ago

ok I cleaned up the commits a bit. The tests were hung up on lingering class declarations in the specs sometimes, depending on order of execution. This PR is passing mri 2.2.0, 2.2.1, and 2.3.0; it is running with current AF.

awead commented 8 years ago

Looks good, although why test 2.2.0 and 2.2.1? We could just support 2.3 and encourage folks to update their rubies. Also, can you squash up the commits? That first one is particularly bad. :smile:

barmintor commented 8 years ago

I'm happy to remove 2.2.0 and squash, though I like keeping the travis config changes in their own commits personally. Do you want me to squash the others?

On Wed, Apr 6, 2016 at 1:06 AM, Adam Wead notifications@github.com wrote:

Looks good, although why test 2.2.0 and 2.2.1? We could just support 2.3 and encourage folks to update their rubies. Also, can you squash up the commits? That first one is particularly bad. [image: :smile:]

— You are receiving this because you were assigned. Reply to this email directly or view it on GitHub https://github.com/projecthydra-labs/fedora-migrate/pull/53#issuecomment-206119374

awead commented 8 years ago

@barmintor yeah, that'd be great. I'm happy to merge it once that's done.