samvera-labs / ldpath

Ruby parser for the LDPath language
http://marmotta.apache.org/ldpath/language.html
Other
9 stars 5 forks source link

optionally return results as literals #18

Open elrayle opened 4 years ago

elrayle commented 4 years ago

Fixes #16 Optionally have ldpath return RDF::Literals instead of Strings

DEFAULT remains returning results as string or the specified data type

Also...

jrochkind commented 4 years ago

Should there be docs somewhere documenting the new param and what it does? Either method-level comment docs on the methods that take the new arg, or README, or something?

I had trouble figuring out what it did at first looking at the code -- is it the difference between returning a String (?) and an RDF::Literal object? Should we think about if there's a clearer name for that then maintain_literals, since once it's released it'll be hard to change? (There may not be a clearer name).