search

samvera-labs / ldpath

Ruby parser for the LDPath language
http://marmotta.apache.org/ldpath/language.html
Other
9 stars 5 forks source link

replace linkeddata dependency with rdf and nokogiri #20

Closed jrochkind closed 4 years ago

jrochkind commented 4 years ago

the linkeddata gem (https://github.com/ruby-rdf/linkeddata/) is an omnibus/metadistribution of large parts of the rdf_rb ecosystem, including "all parsing/serialization plugins." ldpath isn't actually using them all. By replacing dependency with only the sub-parts of linkeddata actually being used, we can dramatically reduce the dependency tree of anything downstream from ldpath, reducing install time and install size for those downstream things, and eliminating unnecessary dependency tree conflict potential.

rdf and nokogiri appear to be the only dependencies of linkeddata gem that are actually used by ldpath.

Please note: I am not actually familiar with the ldpath code or related code, this PR is just based on mechanically trying to get tests to pass with reduced dependencies. If test coverage is poor, this might not be a reliable change? If there are other reasons not captured by tests that removing linkeddata as a dependency could be disruptive for downstream? I rely on code review from ideally someone more familiar with this ecosystem to give us confidence that this makes sense, maybe @no-reply ?

Closes #19

jrochkind commented 4 years ago

Failing tests appears unrelated to me. 

Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
     bundler (~> 1.5)

(Tests all pass locally for me)