search

samvera-labs / ramp

Interactive, IIIF powered audio/video media player React components library. Styleguidist Docs: https://samvera-labs.github.io/ramp/
https://ramp.avalonmediasystem.org/
30 stars 5 forks source link

Scrubbing doesn't work in native player on demo site #516

Closed elynema closed 3 months ago

elynema commented 4 months ago

Description

When testing the demo site in the iOS native player, scrubbing using the progress bar and the forward / backward 10 seconds buttons is not working at all. When the progress bar is dragged, the bar moves, but the video doesn't actually advance. When you click the forward / backward 10 seconds buttons, nothing happens to the video; it just continues playing.

I tested this in iPhone in Browserstack iOS 17 on the Ramp demo site, as well as iOS 16 on my local device. Scrubbing in the native player is working on mco-staging and on avalon-dev, so this must have been recently introduced in a Ramp change.

Could this be related to fixes for the slow scrubbing in #494?

Example from iOS 17 on Ramp demo site

Jun-11-2024 10-14-03

Done Looks Like

joncameron commented 4 months ago

Odd rendering of VTT as well—text is left-aligned with an unexpected background color. Is this related to the same problem? If not we can create a new ticket to fix.

elynema commented 3 months ago

Scrubbing does now seem to be working in the native player on the demo site. It is no longer working on avalon-dev, so leaving this here to finish QA once this Ramp build is pulled into Avalon.

elynema commented 3 months ago

@charumitraravi Can you QA this?

charumitraravi commented 3 months ago

QA completed. Scrubber is working as expected on the native player