Closed Dananji closed 5 days ago
Some is changed in recent refactor work but not all. Mobile (iOS) scrubbing is still off and there's some more work to build on the native VideoJS component to update the behavior.
Dananji noticed some jumping in seeking in Browserstack, but it was smoother on her device. Android is smoother than iOS.
I'm going to go ahead and close this as we've had lots of testing of scrubbing across all platforms and opened multiple other tickets.
Description
A considerable amount of change was made to the custom progress bar component as it was re-architected to use Video.js'
SeekBar
component instead of building the HTML as part of #618. With this work the scrubbing in iOS is not as smooth as it is in the native VideoJSSeekBar
component (the expected outcome). The hierarchy of component structure forProgressControl
in Video.js is as follows;And in the current implementation we are using
SeekBar
and its children, notProgressControl
. I tried attaching the custom seek bar (the implementation merged in #635) toProgressControl
instead of exporting as it is with the following code;But the child component in
MouseTimeDisplay
was facing issues with finding the custom seek bar fed intoProgressControl
. To solve this we can try customizing the children components that are having issues?Done Looks Like
ProgressControl