search

samvera / active_fedora

A Rails interface to the Fedora repository, akin to ActiveModel
Other
54 stars 63 forks source link

Pin the version of rails that is used #1377

Closed jcoyne closed 5 years ago

jcoyne commented 5 years ago

rather than the version of activemodel.

This prevents the tests from installing rails 0.9.5, and not finding the generator code we depend on.

jcoyne commented 5 years ago

This fails due to:

Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    rails (= 4.2.10) was resolved to 4.2.10, which depends on
      bundler (>= 1.3.0, < 2.0)
  Current Bundler version:
    bundler (2.0.1)
jcoyne commented 5 years ago

I recommend that we drop Rails 4.2 from the test matrix.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.05%) to 89.569% when pulling b8e22e59bc85dc8d113f660445609f58520247c1 on pin_rails into 4a6fd5f99710346fdadda134987c10eaa4a12526 on master.

jcoyne commented 5 years ago

This looks great. Can someone do a "squash merge"?

jrochkind commented 5 years ago

y'all know the actual code you merged, according to the github diff, seems to have nothing to do with rails (contra PR title), but does deal with pinning bundler versions?

no-reply commented 5 years ago

@jrochkind I think that was discussed above, here: https://github.com/samvera/active_fedora/pull/1377#discussion_r261300324