samvera / active_fedora

A Rails interface to the Fedora repository, akin to ActiveModel
Other
54 stars 63 forks source link

no _dump_data is defined for class Thread::Mutex #1378

Open jcoyne opened 5 years ago

jcoyne commented 5 years ago
     Failure/Error: marshalled = Marshal.dump(post)

     TypeError:
       no _dump_data is defined for class Thread::Mutex
     # ./spec/integration/marshal_spec.rb:23:in `dump'
     # ./spec/integration/marshal_spec.rb:23:in `block (3 levels) in <top (required)>'

This started occuring around Nov 7, 2018. Is it possible this is correlated with ActiveTriples 1.1.0?

passing: https://travis-ci.org/samvera/active_fedora/builds/449013449 failed: https://travis-ci.org/samvera/active_fedora/builds/452041167

jcoyne commented 5 years ago

diff:

< Fetching concurrent-ruby 1.1.0
> Fetching concurrent-ruby 1.1.3

< Using rack 1.6.10
> Fetching rack 1.6.11

< Using tins 1.17.0
> Fetching tins 1.19.0

> Fetching rdf 3.0.6
< Using rdf 3.0.5
jcoyne commented 5 years ago

Rdf 3.0.6 was released in that timeframe and added a Mutex: https://github.com/ruby-rdf/rdf/releases/tag/3.0.6

cjcolvar commented 5 years ago

I reverted to rdf 3.0.5 and the failing tests passed. I think we should pin to rdf 3.0.5 for now and fix this in rdf by implementing marshal_dump and marshal_load. I'm working on a PR to rdf now.