Closed no-reply closed 5 years ago
As noted, this method is hit by a callback. We have a few options:
Option 1 seems like it might overflow logs in CI. Option 2 seems better if it isn't too much work. For option 3, do we know if anyone has actually overridden this method? If not, then maybe the release notes are fine enough?
i think the proposed approach works, and may avoid the need to bump the major version #1405
This method can be replaced by
ActiveModel::Dirty#changes_applied
, which is more resiliant to changingActiveModel
andRails
behavior.However, since we call it in a callback, and downstream users may be relying on that fact to trigger calls to their overrides, we can't avoid calling it locally until a 14.0.0 release.