search

samvera / active_fedora

A Rails interface to the Fedora repository, akin to ActiveModel
Other
54 stars 63 forks source link

Updating the EBUCore term for `RDF::Vocab::EBUCore.filename` #1421

Closed jrgriffiniii closed 4 years ago

jrgriffiniii commented 4 years ago

This is necessary given that this term was removed: https://github.com/ruby-rdf/rdf-vocab/blob/develop/lib/rdf/vocab/ebucore.rb#L7117. Please see https://github.com/samvera/hydra-derivatives/pull/221 for context.

jrgriffiniii commented 4 years ago

I am not certain why the CircleCI status for my fork is not displaying here: https://app.circleci.com/pipelines/github/jrgriffiniii/active_fedora/49/workflows/5af86cf0-f082-4e00-aba8-ecd23944a423

I will attempt to update the configuration and force-push to my branch.

no-reply commented 4 years ago

this needs backports to 11.x, and other supported AF versions

no-reply commented 4 years ago

looking at this closer, i think we should revert it.

changing this predicate is going to require users with existing data to migrate all existing objects.

jrgriffiniii commented 4 years ago

A new clone of hyrax 3.0.0-rc1 installs 3.0.14 of rdf-vocab for me, and this release still offers the filename property.

no-reply commented 4 years ago

it looks to me like the change was first released in v3.1.5 https://github.com/ruby-rdf/rdf-vocab/commit/d07779dbcc4cca5c34a96d6118c4aa8ee23673a9