search

samvera / active_fedora

A Rails interface to the Fedora repository, akin to ActiveModel
Other
54 stars 63 forks source link

remove `StandardFilterFactory` #1424

Closed no-reply closed 4 years ago

no-reply commented 4 years ago

StandardFilterFactory hasn't done anything since Solr 3. Remove it for better forward support.

no-reply commented 4 years ago

sorry about the whitespace changes. i can isolate those, if we'd prefer, but it's a pain (my editor is configured to remove trailing whitespace) and it seems good to remove it anyway, since this gets injected into applications.

rotated8 commented 4 years ago

As an aside, in GitHub, you can hide whitespace changes from the diff by adding ?w=1 to the end of the url on the files tab, e.g. https://github.com/samvera/active_fedora/pull/1424/files?w=1