search

samvera / active_fedora

A Rails interface to the Fedora repository, akin to ActiveModel
Other
54 stars 63 forks source link

Rewording constants for greater accessibility #1430

Open jeremyf opened 4 years ago

jeremyf commented 4 years ago

Related to https://github.com/samvera/hyrax/commit/ad5e64590f91a8fdf2c3ff812b278ba73eee487e

cjcolvar commented 4 years ago

I'm :+1: to this change. Do you think these constants are part of the public API that would require a major version bump? If so, then we probably need deprecation warnings.

no-reply commented 4 years ago

looks like this needs a rebase.

we could mitigate the major version situation by aliasing the constants for the time being?