samvera / active_fedora

A Rails interface to the Fedora repository, akin to ActiveModel
Other
54 stars 63 forks source link

Short circuit ActiveModel::Dirty for nodes_will_change! #1441

Closed cjcolvar closed 3 years ago

cjcolvar commented 3 years ago

ActiveModel::Dirty will attempt to load the entire ordered list when calling nodes_will_change! which leads to a stack level too deep exception in some cases (https://github.com/samvera/hyrax/issues/4581).

This approach was also taken in ActiveFedora::File: https://github.com/samvera/active_fedora/pull/1312/commits/7c8bbbefdacefd655a2ca653f5950c991e1dc999#diff-28356c4daa0d55cbaf97e4269869f510R100-R103