search

samvera / active_fedora

A Rails interface to the Fedora repository, akin to ActiveModel
Other
54 stars 63 forks source link

Short circuit ActiveModel::Dirty for nodes_will_change! #1442

Closed cjcolvar closed 3 years ago

cjcolvar commented 3 years ago

ActiveModel::Dirty will attempt to load the entire ordered list when calling nodes_will_change! which leads to a stack level too deep exception in some cases (samvera/hyrax#4581).

This approach was also taken in ActiveFedora::File: 7c8bbbe#diff-28356c4daa0d55cbaf97e4269869f510R100-R103

no-reply commented 3 years ago

should this go to master first?

no-reply commented 3 years ago

this was already removed/fixed in AF 13+. merging it for release in 12.x