Fix obsolete URI.encode call

samvera / active_fedora

A Rails interface to the Fedora repository, akin to ActiveModel

Other

54 stars 63 forks source link

Fix obsolete URI.encode call #1476

Closed jrgriffiniii closed 1 month ago

jrgriffiniii commented 2 years ago

Derived from rebasing https://github.com/samvera/active_fedora/pull/1461

jrgriffiniii commented 2 years ago

This is now rebased and passing on CircleCI (hence, because these are my commits, I will need to please request a review from @samvera/maintenance). Thank you again for the actual updates @apertome!

cjcolvar commented 2 years ago

When making the 12.2.4 release to fix the rdf issue I also backported the fix for this from main (https://github.com/samvera/active_fedora/pull/1474). So I'm not sure if this PR makes sense to do anymore. The approach taken in main is different and looking at the two I would tend to favor the one in main since it doesn't bring in any new dependencies.