Copy newer rails code for rewording or removing poorly named constants

samvera / active_fedora

A Rails interface to the Fedora repository, akin to ActiveModel

Other

54 stars 63 forks source link

Copy newer rails code for rewording or removing poorly named constants #1501

Closed cjcolvar closed 2 weeks ago

cjcolvar commented 1 month ago

Since the changes in #1500 are preparing for a major release the changes proposed in #1430 can be merged without backwards compatibility concerns. I favored the approaches rails took as pointed out by @jcoyne .

Alternative to #1430

cjcolvar commented 1 month ago

Passed automated testing on Hydra-Head, Hyrax, and Avalon. https://github.com/samvera/hydra-head/pull/560/commits/97f98b4dc48364fc2d68379a911dd9cff9701f63 https://github.com/samvera/hyrax/pull/6898 https://github.com/avalonmediasystem/avalon/pull/6022