search

samvera / bulkrax

Bulk Import and Export For Samvera
Apache License 2.0
12 stars 21 forks source link

update the default "split" value #635

Open alishaevn opened 2 years ago

alishaevn commented 2 years ago

summary

now that allinson_flex can be used with bulkrax, we should consider changing the default split value to "true" in default_field_mapping.

since allinson_flex is supposed to handle adding/removing property's on the fly, we don't need to define those properties in "config/initializers/bulkrax.rb" in each client app. however, many users import a multi valued property using a split character and not with numerated headers.

this change would allow for that continued behavior for users using allinson_flex and bulkrax together. it should also not mess up existing behavior

alishaevn commented 2 years ago

@orangewolf @sephirothkod @bkiahstroud @ShanaLMoore @kirkkwang opinions?

bkiahstroud commented 2 years ago

it should also not mess up existing behavior

It might break some implementations if they don't explicitly define split rules and expect values not to split.

Related, there are changes planned for how split works. Making those changes in the context of using Allinson Flex might be a good since it's likely the most dynamic situation Bulkrax would have to handle.

alishaevn commented 2 years ago

hmmm. yeah those would be useful too. thanks!

kirkkwang commented 2 years ago

in UTK there's a MR that checks for AllinsonFlex profiles, maybe something like that and set it to true if conditions are met?

https://gitlab.com/notch8/utk-hyku/-/merge_requests/83/diffs#3ebc2864d890372340663389de3c9fe45fc07fe2_0_9

alishaevn commented 2 years ago

in UTK there's a MR that checks for AllinsonFlex profiles, maybe something like that and set it to true if conditions are met?

that could be a possibility, but I'm thinking more of changing the split value to be more accessible/dynamic overall....not just when AF is installed. having AF installed however is one of the use cases that makes a more dynamic approach necessary.