samvera / bulkrax

Bulk Import and Export For Samvera
Apache License 2.0
12 stars 21 forks source link

:bug: Refactor: Fix file path access to prevent error #966

Closed ShanaLMoore closed 2 months ago

ShanaLMoore commented 2 months ago

Summary

When testing the OAI importer on Adventist valkyrie, we received the following error. The error was caused because oai imports from a feed, so no original file exists. When checking, instead of returning false it returned nil, and thus caused a TypeError.

related:

Screenshots / Video

BEFORE

Screenshot 2024-08-02 at 14-37-00 Action Controller Exception caught

AFTER

image

Expected Behavior

The site will not break when an original file doesn't exist.

Notes

:bug: Refactor: Fix file path access to prevent error

970ad45906b1db6f02f19679f723318da4c22418