search

samvera / hydra-derivatives

Derivative generation for Samvera repositories
Other
17 stars 25 forks source link

Expand build matrix #127

Closed atz closed 7 years ago

atz commented 7 years ago

This test suite runs in less than a minute, we can afford to flesh out the build matrix for better coverage and earlier detection of deprecations.

atz commented 7 years ago

So I think this demonstrates we have issues supporting newer rubies.

atz commented 7 years ago 
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
    can't modify frozen String
Gem files will remain installed in
/home/travis/build/projecthydra/hydra-derivatives/vendor/bundle/ruby/2.4.0/gems/rainbow-2.2.1
for inspection.
Results logged to
/home/travis/build/projecthydra/hydra-derivatives/vendor/bundle/ruby/2.4.0/extensions/x86_64-linux/2.4.0/rainbow-2.2.1/gem_make.out
An error occurred while installing rainbow (2.2.1), and Bundler cannot
continue.
Make sure that `gem install rainbow -v '2.2.1'` succeeds before bundling.

I had similar problems locally w/ 2.4 (and other problems w/ older rubies), but was able to install rainbow simply with gem install rainbow. I don't know why the same version failed in a bundler context but succeeded in an individual context. 

> bundle show rainbow
/Users/atz/.rvm/gems/ruby-2.4.0/gems/rainbow-2.2.1

After that the bundle installed cleanly.

atz commented 7 years ago

So I added before_script: gem install rainbow and it succeeds, with the correct version, but then still fails trying to re-install it during bundle install. Color me confused.

cbeer commented 7 years ago

I believe this is a well-known issue with bundler? rubygems? and can be fixed by:

https://github.com/projectblacklight/blacklight/blob/master/.travis.yml#L20-L22

atz commented 7 years ago

Feel free to squash-merge this if the workaround is successful.