samvera / hydra-derivatives

Derivative generation for Samvera repositories
Other
17 stars 25 forks source link

Add active_encode support to hydra-derivatives #161

Closed cjcolvar closed 7 years ago

cjcolvar commented 7 years ago

The ActiveEncode runner allows using ActiveEncode within hydra-derivatives to generate derivatives using the adapters supported by ActiveEncode. Currently Amazon Elastic Transcoder is the only production ready adapter available but prototypes exist for zencoder and shingoncoder (FFmpeg through ActiveJob). The key differences between ActiveEncode and hydra-derivatives are:

In support of this a source file service and output file service have been added. The RemoteServiceFile takes the :source option and calls a method of that name on the source object to determine the source file path or url to send to the processor. The PersistExternalFileOutputService creates an ActiveFedora::File with a url to the derivative output instead of storing the actual bit contents of the derivative in Fedora.

Documentation is added for configuring and using the ActiveEncode runner with Amazon Elastic Transcoder which seems like the main use case for users at this point.

Thanks to @val99erie for a lot of this work.

cjcolvar commented 7 years ago

@cam156 Thanks for your comments. I think I responded or handled them in the last commit I pushed. @mjgiarlo Do you mind reviewing as well since you looked over things while they were WIP?

mjgiarlo commented 7 years ago

@cjcolvar You bet.

cjcolvar commented 7 years ago

@mjgiarlo I think I took care of everything that isn't documentation or comments changes. I'll come back to those later today/tomorrow.

mjgiarlo commented 7 years ago

@cjcolvar OK, thanks! Ping me when it's :green_heart: and all ready to go.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling ee0ad3fcce5729ed4b185beed13b4a8fe2380522 on active_encode_dev_con into on master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling ee0ad3fcce5729ed4b185beed13b4a8fe2380522 on active_encode_dev_con into on master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling ee0ad3fcce5729ed4b185beed13b4a8fe2380522 on active_encode_dev_con into on master.

cjcolvar commented 7 years ago

@mjgiarlo Ready. Any additional changes you'd like to see?

mjgiarlo commented 7 years ago

@cjcolvar Taking one last look. Thanks for all the changes, and yr patience!

mjgiarlo commented 7 years ago

:tada: Thanks for the contribution! Great work. (Do you want/need a new release now that this is merged?)