search

samvera / hydra-derivatives

Derivative generation for Samvera repositories
Other
17 stars 25 forks source link

added ssl check to turn on use_ssl on req object; plus specs #173

Closed RudyOnRails closed 6 years ago

RudyOnRails commented 6 years ago

Hope this is acceptable! 🤞

PS: I emailed my iCLA last week to legal@samvera.org

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.07%) to 86.557% when pulling 4037b8c44444472daedf970ae9d770913d895219 on RudyOnRails:ssl_fix_pr into ead874daa87bb6c63be82b00a3b63474033f9dc2 on samvera:master.

jcoyne commented 6 years ago

Hold tight @RudyOnRails. We're still processing that iCLA. Other than that it looks good.

RudyOnRails commented 6 years ago

@jcoyne @mjgiarlo green light? and I'm not sure if I opened this against the correct branch either :/

mjgiarlo commented 6 years ago

Thanks, @RudyOnRails!

RudyOnRails commented 6 years ago

Thank me after it's been in production for a month! :)

On Fri, Nov 17, 2017, 3:19 PM Michael J. Giarlo notifications@github.com wrote:

Thanks, @RudyOnRails https://github.com/rudyonrails!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/samvera/hydra-derivatives/pull/173#issuecomment-345368067, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-U4gzKNz14BapVrDCWNdBiidgxukuNks5s3fhYgaJpZM4Qd-v5 .

--

-Please excuse any errors or brevity, I'm mobile!