search

samvera / hydra-derivatives

Derivative generation for Samvera repositories
Other
17 stars 25 forks source link

Backwards breaking change in hydra-derivatives 3.4.0, Hydra::Derivatives::IoDecorator#original_name= #181

Closed jrochkind closed 6 years ago

jrochkind commented 6 years ago

In hydra-derivatives 3.3.0, Hydra::Derivatives::IoDecorator has an #original_name= method.

In hydra-derivatives 3.4.0, it does not. https://github.com/samvera/hydra-derivatives/commit/0cdd8ba9aefe75c437e5089806479a6755151639#diff-5393e82239735e5d752d1db7e05c5702

curation-concerns 1.7.8 tries to use #original_name=, and sufia CI breaks cause it's not there anymore in 3.4.0.

I think this is a buggy backwards-breaking change, and the method should be restored?

I see the attempt is to deprecate original_name for original_filename. The writer version needs to be added back with deprecation maybe?

Ref: https://github.com/samvera/sufia/pull/3183