search

samvera / hydra-editor

A basic editor for samvera objects.
Other
10 stars 13 forks source link

Rails 6 support #203

Closed cjcolvar closed 2 years ago

cjcolvar commented 2 years ago

Builds on #192 and #201. Supersedes #202. Fixes #184.

Add support for Rails 6.0 and run javascript tests with jasmine-browser-runner. Some small fixes were needed to get the javascript tests to pass.

This would probably constitute a new major version because it drops support for Rails versions < 5.2 and ruby < 2.5. Rails 6.1 currently fails when trying to include Hydra::AccessControls::Permissions (See this failed circleci run)

hackartisan commented 2 years ago

🎉 nice work y'all thanks for getting it over the line!

jrochkind commented 2 years ago

Nice work! Interesting to note this is almost all "test setup" changes, no changes really had to be made to functionality, just to test setup.