Full tests for PR 126 - Githubissues

samvera / hydra-pcdm

Samvera implementation of the PCDM model

Other

11 stars 10 forks source link

Full tests for PR 126 #130

Closed elrayle closed 9 years ago

elrayle commented 9 years ago

Tests for PR https://github.com/projecthydra-labs/hydra-pcdm/pull/126/files

Identifies the following systematic failures:

<< fails to add object
<< does not validate
objects= uses a different process from objects<<, object+=, members=, members<<, members+=
object= a produce difference validation error message than the other setters (due to using different processes)
error message states that the argument for child objects can be either a pcdm object or collection. Message should state only pcdm object should be allowed.

elrayle commented 9 years ago

NOTE: Tests do fail, but that is only because the tests cover more functionality. This PR only adds tests.

elrayle commented 9 years ago

Either merge this PR or PR https://github.com/projecthydra-labs/hydra-pcdm/pull/131.

The same updates for object_spec are in both PRs. PR 131 also includes the parent/child API rework.

elrayle commented 9 years ago

DO NOT MERGE - I am creating a passing set of tests and will create issues for the ones that fail.

elrayle commented 9 years ago

I will make a new PR when it is ready.

mjgiarlo commented 9 years ago

:ok: :clap:

elrayle commented 9 years ago

When complete, https://github.com/projecthydra-labs/activefedora-aggregation/issues/44 may resolve the following...

<< fails to add object
<< does not validate

When complete, https://github.com/projecthydra-labs/hydra-pcdm/issues/137 may resolve the following...

objects= uses a different process from objects<<, object+=, members=, members<<, members+=
object= a produce difference validation error message than the other setters (due to using different processes)
error message states that the argument for child objects can be either a pcdm object or collection. Message should state only pcdm object should be allowed.

jcoyne commented 9 years ago

As far as I can tell, none of the tests are failing on "<< fails to add object". All the failing tests are around "Hydra::PCDM::Object#members= ..." and "Hydra::PCDM::Object#objects= ..." See also: https://github.com/projecthydra-labs/activefedora-aggregation/pull/49 What am I missing?