samvera / hydra-pcdm

Samvera implementation of the PCDM model
Other
11 stars 10 forks source link

Add Object#child_object_ids #141

Closed jcoyne closed 9 years ago

mjgiarlo commented 9 years ago

:+1:

scherztc commented 9 years ago

Code reading up on indexers, child_objects, and pcdm.

When I ran the test locally I got a Syntax error in:

/hydra-pcdm/spec/hydra/pcdm/models/collection_spec.rb:73: syntax error, unexpected ')' (SyntaxError)

Are these test meant to only run on travis?

jcoyne commented 9 years ago

@scherztc the tests should run the same anywhere. They work on my machine and on Travis. Are you sure you have a clean checkout?

scherztc commented 9 years ago

Fresh clone, clean checkout, bundle update, rake spec,....

Still getting error. I am on ruby-2.0.0-p247.

Same method in either object_spec or collection_spec.

def build_proxy(container:) instance_double(ActiveFedora::Aggregation::Proxy, container: container) end

ruby version?

jcoyne commented 9 years ago

have you tried bundle exec rspec ? I'm using ruby 2.2.2.

scherztc commented 9 years ago

yes. I will try an updated ruby version.

jcoyne commented 9 years ago

Oh, yeah, that code has required keyword arguments which is a ruby 2.1 feature. Blame @terrellt :exclamation:

scherztc commented 9 years ago

All test passing locally with ruby 2.1.5. I will merge.