Fixing foreign_key for ActiveFedora:Aggregation::Proxy

samvera / hydra-pcdm

Samvera implementation of the PCDM model

Other

11 stars 10 forks source link

Fixing foreign_key for ActiveFedora:Aggregation::Proxy #231

Closed escowles closed 8 years ago

escowles commented 8 years ago

When plugging the recent changes into CurationConcerns, I discovered that I had been misreading the tests and confusing a stub Proxy class (which has a proxy_for method) for AF::Aggregation::Proxy (which has target and container methods). This PR corrects the usage to use AF::Aggregation::Proxy#target.

Sorry for the churn on this.

coveralls commented 8 years ago

Coverage remained the same at 99.576% when pulling 22c192b1b71e8fbe4b13426a57584bd5d8b2be2c on member_of_3 into f8349d74c30d1a41a3155844b45582fc638979c4 on master.

mjgiarlo commented 8 years ago

@escowles Can you write a test that fails if this code change is undone?

escowles commented 8 years ago

@mjgiarlo I've pushed a branch with just the intermediate commit, which adds a object.save call to the test to demonstrate the failure before the last commit fixes it.