search

samvera / hydra-pcdm

Samvera implementation of the PCDM model
Other
11 stars 10 forks source link

Provide tooling for reversing nested collection relationships #244

Closed cjcolvar closed 7 years ago

cjcolvar commented 7 years ago

This PR allows for reversing the collection->sub-collection relationship. It leverages the work @escowles did (#227) for reversing the collection->object relationship by pulling the relavant code up from the object module into the pcdm module for model behavior and indexer. This will increase the performance for collections with many sub-collections which may be more common in dSpace instances.

Future work could be allowing the object->object relationship to be reversed. This could set the stage for a refactoring of the model behaviors and possibly other modules and classes in hydra-pcdm.

Resolves #243.

elrayle commented 7 years ago

The changes here look good to me. I am hoping we can get this merged today or tomorrow which will allow https://github.com/samvera/hydra-works/pull/333/files to be finalized and merged as well.

Any comments or others who want to review before this is merged? @escowles @jcoyne