search

samvera / hydra-pcdm

Samvera implementation of the PCDM model
Other
11 stars 10 forks source link

Forces Circle to report build status to Coveralls #279

Closed rotated8 closed 4 years ago

rotated8 commented 4 years ago

When using parallel builds, Coveralls does not always know when a build is completed. Circle's deploy step only happen if the other parallel nodes finish successfully. Therefore, we can use the deploy step to tell Coveralls, once per build, that a build has completed successfully.

In support of this, the Coveralls repository token has been added to CircleCI for the hydra-pcdm project.

rotated8 commented 4 years ago

@jrgriffiniii In checks, this branch shows 100% coverage. Should I move the rdf-vocab pin into it's own PR?

jrgriffiniii commented 4 years ago

Thank you very much for this @rotated8 ,I think that just including that change in this PR is acceptable.