search

samvera / hydra-role-management

User roles for hydra users
Other
6 stars 11 forks source link

Upgrade issues #16

Closed mkorcy closed 9 years ago

mkorcy commented 9 years ago

@jcoyne OK -- this changes how cancel is handled, passes all tests, and works in MIRA.

jcoyne commented 9 years ago

This changes the behavior of the redirection, so we need some community consensus on that. @bf4 @cjcolvar do you have an opinion on this?

jcoyne commented 9 years ago

/cc @bf4

jcoyne commented 9 years ago

@mkorcy You should probably write to hydra-tech asking if there is anyone who uses this gem and has objections about changing where the redirects go.

cjcolvar commented 9 years ago

@jcoyne We don't actually use this yet so I don't have a strong opinion.

mkorcy commented 9 years ago

I wasn't really tied to changing that, I'll just restore the redirect

mkorcy commented 9 years ago

@jcoyne I restored the edit redirects, and also fixed all the deprecations in rspec for should/expect.

mkorcy commented 9 years ago

@jcoyne can you point me to how i'd go about asking for a release to point to in mira?

jcoyne commented 9 years ago

@mkorcy Do you have an account on rubygems.org? If not can you make one, then tell me what it is?

mkorcy commented 9 years ago

it is mkorcy

On Thu, Dec 18, 2014 at 9:39 AM, Justin Coyne notifications@github.com wrote:

@mkorcy https://github.com/mkorcy Do you have an account on rubygems.org? If not can you make one, then tell me what it is?

— Reply to this email directly or view it on GitHub https://github.com/projecthydra/hydra-role-management/pull/16#issuecomment-67494003 .

jcoyne commented 9 years ago

@mkorcy I've added you to the gem owners on rubygems.org. I've invited to to be a collaborator on projecthydra and projecthydra-labs. Now you can do the release yourself. Here are some guidelines to follow: https://wiki.duraspace.org/pages/viewpage.action?pageId=31662096 For hydra-role-management, you can probably skip the "release candidate" step.

jcoyne commented 9 years ago

@mkorcy You release the gem by incrementing the version in /lib/hydra/role_management/version.rb then committing the change, then running rake release

mkorcy commented 9 years ago

@jcoyne 0.2.1, correct? so for this case, skip the RC, do the release as described above, add release notes to the release on github, email hydra-tech?

jcoyne commented 9 years ago

Yes, sounds good.

bf4 commented 9 years ago

@jcoyne Just seeing this. I don't recall why you might be cc'ing me, but thanks, I guess. Did you perhaps mean someone else?