Integrates CircleCI for continuous integration

samvera / hydra-role-management

User roles for hydra users

Other

6 stars 11 forks source link

Integrates CircleCI for continuous integration #45

Closed jrgriffiniii closed 5 years ago

jrgriffiniii commented 5 years ago

Resolves #44

tpendragon commented 5 years ago

@jrgriffiniii Why the complicated workflow? Are we getting something from separating bundle/lint from everything else?

cjcolvar commented 5 years ago

Since this gem requires an engine cart generate and multiple ruby versions being tested, I think it makes sense to have a separate build (bundle, lint, generate) job from the test jobs. Hyrax separates out the lint step so it can run in parallel to the generate step. I'm not sure if it is really worth it for this gem given it is much smaller than hyrax.

tpendragon commented 5 years ago

Coveralls didn't report back. Did you add the COVERALLS_REPO_TOKEN to the CircleCI environment variables @jrgriffiniii ?

coveralls commented 5 years ago

Coverage decreased (-0.2%) to 98.922% when pulling 95ce17d716e529847a9730dffbc216712cdb13f4 on jrgriffiniii:issues-44-jrgriffiniii-circleci into 2918cf02bfb8658e8a5abdcc876f6c5fee86d5c2 on samvera:master.

jrgriffiniii commented 5 years ago

Coveralls is now reporting for this.