Allow for later json versions

samvera / hydra-role-management

User roles for hydra users

Other

6 stars 11 forks source link

Allow for later json versions #52

Closed bess closed 5 years ago

bess commented 5 years ago

Do we need to pin the json gem to version 1.8? The test suite seems to run fine with 2.x versions of json, and having it pinned at 1.8 is preventing applications that use hydra-role-management from running on recent systems that come with json 2.x installed by default.

This PR indicates the need for json greater than or equal to 1.8.

Connected to https://github.com/samvera/hydra-role-management/issues/53

jrgriffiniii commented 5 years ago

If I recall correctly, adjusting the json dependency triggered test failures, but those changes were from May 2018. I will merge this if the tests are passing on CI.

coveralls commented 5 years ago

Coverage remained the same at 98.922% when pulling caa345e6f2ed53df6caafefeeb34de450892b3f7 on remove_json_version_pin into 3bb71b9260e7202c7f620f6ef28f19ce6641d401 on master.