search

samvera / hydra-works

A ruby gem implementation of the PCDM Works domain model based on the Samvera software stack
Other
24 stars 14 forks source link

Add indexer for child generic works #175

Closed tpendragon closed 9 years ago

tpendragon commented 9 years ago

Closes #109

jcoyne commented 9 years ago

Why does Hydra-Works need to index it's child generic works? What's the real use case? I think CurationConcerns already does this and it'd be extra slow to have it happen more than once.

escowles commented 9 years ago

None of the specs say anything about how it would be used -- they just check the solr_doc for the ids.

Unless it's needed for the characterization, derivatives, etc., I'm fine with just getting rid of it.

escowles commented 9 years ago

Related, there are a total of 7 tests that use to_solr -- and all of them are skipped because of #109. There are no uses of to_solr in the main code at all. So I'm for just removing those tests.

tpendragon commented 9 years ago

I'd expect it to be needed at the Sufia level, but if Curation Concerns can handle it, then I'm alright with it.

escowles commented 9 years ago

I've opened #177 to remove the solr tests.