search

samvera / hydra-works

A ruby gem implementation of the PCDM Works domain model based on the Samvera software stack
Other
24 stars 14 forks source link

Migrating virus check functionality from CurationConcerns #178

Closed escowles closed 9 years ago

escowles commented 9 years ago

Addresses #94 (part 1 of 2)

jcoyne commented 9 years ago

This seems like business logic more than modeling. As such does it belong in hydra-works? I'm not against it being here, I'm just making sure we're considering it thoughtfully.

escowles commented 9 years ago

@jcoyne I think the reasoning for moving this down to hydra-works is to have all of the core functionality here (generating derivatives, creating versions, checking for viruses, etc.) so you don't have to use curation_concerns to get that functionality.

jcoyne commented 9 years ago

Yes, I now see that derivatives are here, so it probably belongs with that.

jcoyne commented 9 years ago

Should there be something added to the Readme saying "Add clamav to your gemfile to enable virus checking"?

jpstroop commented 9 years ago

Close projecthydra-labs/curation_concerns#37 and move this part of CurationConcern's README here when this goes through.

mjgiarlo commented 9 years ago

@escowles Do you want to include the README change that @jpstroop suggests in this PR, or attach that to part 2?

:+1:

escowles commented 9 years ago

@mjgiarlo I'll add the README update to this PR -- and then part 2 will be updating curation_concerns to use this virus check instead of its own

jpstroop commented 9 years ago

Actually, it's even more than that; virus check is also in CurationConcerns :cry: , so that should be removed. I'll update projecthydra-labs/curation_concerns#37

jpstroop commented 9 years ago

Doh!

mjgiarlo commented 9 years ago

@escowles OK. I'll merge this PR as soon as you tweak the README. (I won't bother waiting on travis for a README change -- we already know the suite passes.) Ping me when that's ready.