Test coverage for Hydra::Works::GenericFile::Derivatives.

samvera / hydra-works

A ruby gem implementation of the PCDM Works domain model based on the Samvera software stack

Other

24 stars 14 forks source link

Test coverage for Hydra::Works::GenericFile::Derivatives. #183

Closed tampakis closed 9 years ago

tampakis commented 9 years ago

Closes #152.

Included all sufia-models derivatives in GenericFile::Derivatives.
GenericFile now directly contains all of the derivatives defined for GenericFile.
Update readme to show how to configure additional derivatives.
Skip ffmpeg-related specs and sofice specs for Travis because they are not configured. Is this something we should consider supporting in CI?
Ensure that files are readable. Some of the processors in H::Derivatives pass raw binary strings instead of IO objects.
Re-add mime_type as an option for AddFileToGenericFileService because IO objects don't respond to .mime_type. All H:Derivative processors pass the mime_type option to the output_file_service.

grosscol commented 9 years ago

Instead of adding mime_type to the signature to accommodate the HydraDerivatives use, we're going to refactor HydraDerivatives to wrap the IO objects in a class that has their attributes. This will be similar to how CurationConcerns operates.

mjgiarlo commented 9 years ago

This PR is blocked by the hydra-derivatives work @grosscol referenced above. Once that's done, this PR should depend upon that work and change the way it handles MIME types.

tpendragon commented 9 years ago

This looks okay to me, but I haven't dug too deep into the derivatives stuff. @mjgiarlo @tampakis?

tpendragon commented 9 years ago

https://coveralls.io/builds/3251106/source?filename=lib%2Fhydra%2Fworks%2Fprocessor.rb#L5 Any idea why this is no longer covered?

mjgiarlo commented 9 years ago

:+1:

tampakis commented 9 years ago

The processor is no longer needed because of the RetrieveSourceFile service in Derivatives. I just updated the gemfiles and gemspecs. Feel free to rebase. I'll be on a plane during the call today.